Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 880473002: dart2js: move emitClass to emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, zarah, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: move emitClass to emitter. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 3 chunks +17 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
In a future step the call to `prepare` happens in the ProgramBuilder. This is just ...
5 years, 10 months ago (2015-01-26 13:15:58 UTC) #2
herhut
lgtm
5 years, 10 months ago (2015-01-26 13:31:40 UTC) #3
floitsch
5 years, 10 months ago (2015-01-26 13:44:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43133 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698