Disable analysis in hidden directories (fix for issue 22170)

Disable analysis in hidden directories (fix for issue 22170)

R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43485

[Brian Wilkerson, 2015-02-04 18:31:27]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-02-04 18:39:52]

lgtm.

Should we document this new behavior somewhere?  (I.e. maybe in the analysis
server spec we should say that the contents of folders whose name begins with
"." are not analyzed).

https://codereview.chromium.org/880313006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/880313006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:286: if
(info.excludesResource(folder) || folder.shortName.startsWith('\.')) {
Nit: remove the backslash, since it has no effect.

[Brian Wilkerson, 2015-02-04 21:25:20]

New patchsets have been uploaded after l-g-t-m from paulberry@google.com

[Brian Wilkerson, 2015-02-04 21:26:19]

> Should we document this new behavior somewhere?

Done

https://codereview.chromium.org/880313006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/880313006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:286: if
(info.excludesResource(folder) || folder.shortName.startsWith('\.')) {
Done

[Brian Wilkerson, 2015-02-04 21:28:02]

Committed patchset #2 (id:20001) manually as 43485 (presubmit successful).

[Paul Berry, 2015-02-04 21:34:44]

https://codereview.chromium.org/880313006/diff/20001/pkg/analysis_server/tool...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/880313006/diff/20001/pkg/analysis_server/tool...
pkg/analysis_server/tool/spec/spec_input.html:481: that are not also in one of
the excluded paths and do not start with
IMHO this is ambiguous.  It's not clear whether "do not start with a dot" is
referring to the filename or a path component starting with a ".", and if it's
referring to a path component it's not clear which path component.

If I understand the code change correctly I believe that directories descended
from the analysis root will be excluded from analysis if the directory name
begins with ".", but that files whose names begin with "." will in general still
be analyzed.  Also, if an analysis root contains a path component that begins
with ".", that will not prevent analysis.