Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 879893002: Make RangeError.toString use the name field that it inherits from ArgumentError. (Closed)

Created:
5 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make RangeError.toString use the name field that it inherits from ArgumentError. Refactor the toString code to make it reuse more of the logic and thereby be more consistent. BUG= http://dartbug.com/22148 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43231

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -72 lines) Patch
M sdk/lib/core/errors.dart View 6 chunks +23 lines, -19 lines 0 comments Download
M tests/corelib/range_error_test.dart View 1 1 chunk +71 lines, -53 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 11 months ago (2015-01-27 13:46:56 UTC) #2
Søren Gjesse
lgtm, but add test? https://codereview.chromium.org/879893002/diff/1/sdk/lib/core/errors.dart File sdk/lib/core/errors.dart (right): https://codereview.chromium.org/879893002/diff/1/sdk/lib/core/errors.dart#newcode174 sdk/lib/core/errors.dart:174: String get _errorName => "Invalid ...
5 years, 11 months ago (2015-01-27 15:27:59 UTC) #3
Lasse Reichstein Nielsen
5 years, 10 months ago (2015-01-28 09:39:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698