Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issue 879813002: Tweak a couple of method signatures for unittest methods so that they are more consistent. (Closed)

Created:
5 years, 11 months ago by Jacob
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweak a couple of method signatures for unittest methods so that they are more consistent. BUG= R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=43345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/utf/lib/src/list_range.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/utf/lib/src/utf/utf_stream.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/utf/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jacob
Sending to you as you are an uploader for this package. Feel free to reassign.
5 years, 11 months ago (2015-01-27 01:43:06 UTC) #2
kevmoo
lgtm
5 years, 11 months ago (2015-01-27 01:46:23 UTC) #3
Jacob
5 years, 10 months ago (2015-01-30 21:02:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698