Issue 87953002: Change Expect.identical(NaN, x) to not assume NaNs are identical.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87953002: Change Expect.identical(NaN, x) to not assume NaNs are identical. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen

Modified:
7 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Change Expect.identical(NaN, x) to not assume NaNs are identical. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=30667

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -11 lines)			Patch
M	runtime/lib/double_patch.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/corelib/num_parse_test.dart	View	1 chunk	+11 lines, -3 lines	0 comments	Download
M	tests/lib/math/double_pow_test.dart	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein Nielsen

7 years ago (2013-11-26 10:32:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30667 (presubmit successful).