Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 879373002: Make test context more accurate (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -30 lines) Patch
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 7 chunks +45 lines, -22 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
This makes the element models built for testing more consistent with what would be produced ...
5 years, 10 months ago (2015-01-28 16:52:59 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-01-28 17:09:45 UTC) #3
Brian Wilkerson
5 years, 10 months ago (2015-01-28 17:11:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698