Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 879233005: cps-ir: Correctly bailout on unresolved static calls. (Closed)

Created:
5 years, 10 months ago by karlklose
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cps-ir: Correctly bailout on unresolved static calls. This adds a better error message and the ability to fallback to the old backend when compiling code like this: main() { new foo(); } and class C {} main() { C.foo(); } R=asgerf@google.com, kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=43548

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +18 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
karlklose
5 years, 10 months ago (2015-02-03 14:06:53 UTC) #1
karlklose
Ping.
5 years, 10 months ago (2015-02-06 08:33:53 UTC) #5
asgerf
lgtm https://codereview.chromium.org/879233005/diff/40001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right): https://codereview.chromium.org/879233005/diff/40001/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#newcode212 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:212: /// appropriate error message instead of the static ...
5 years, 10 months ago (2015-02-06 10:12:40 UTC) #6
karlklose
5 years, 10 months ago (2015-02-06 10:36:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as 43548 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698