Issue 879013002: Status file update to reflect now passing enum_test (dartbug.com/21323).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 879013002: Status file update to reflect now passing enum_test (dartbug.com/21323). (Closed)

Created:
5 years, 11 months ago by pquitslund

Modified:
5 years, 10 months ago

Reviewers:
Paul Berry, floitsch, scheglov, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Status file update to reflect now passing enum_test (dartbug.com/21323). R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43200

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pquitslund

Committed patchset #1 (id:1) manually as r43200 (presubmit successful).

5 years, 11 months ago (2015-01-27 19:14:15 UTC) #4

floitsch

5 years, 10 months ago (2015-02-04 15:23:32 UTC) #7

Message was sent while issue was closed.

I think that "Pass, Fail" is a bad idea.

If you don't want to actually run all dart2js tests, then force it to "Pass".
If you want to run the test, then it should probably be "Fail".

From what I could see, it only passes, if you run with --allow-mock-compilation
and use server libraries. That basically means that the generated code doesn't
even enter main.
Note that with a "Pass" I expect you to not run any other test. (you just make
sure that it compiles).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages