Tighten up a couple method signatures to specify that int is required.

Tighten up a couple method signatures to specify that int is required.

BUG=
R=alanknight@google.com

Committed: https://github.com/dart-lang/intl/commit/c5295706761d67143e2d54a91d16d214d26c58bf

[Jacob, 2015-01-27 02:49:00]

jacobr@google.com changed reviewers:
+ alanknight@google.com

[Jacob, 2015-01-27 02:49:00]

Tighten up a couple method signatures to specify that int is required.
I also make the somewhat more questionable change of tweaking a type annotation
from var to num to make the intent clearer as the type of the variable is
sometimes int and sometimes double while it is first assigned to a value with a
RHS of type int.

[Alan Knight, 2015-01-27 21:10:18]

https://codereview.chromium.org/878603009/diff/1/lib/src/intl/number_format.dart
File lib/src/intl/number_format.dart (right):

https://codereview.chromium.org/878603009/diff/1/lib/src/intl/number_format.d...
lib/src/intl/number_format.dart:713: num parsed = int.parse(normalizedText,
onError: (message) => null);
It's minor but I don't love this. Especially when we're compiling to JS, which
doesn't distinguish between ints and doubles, it seems gratuitous.

I don't know if this is a symptom of a more general issue, or if this really
just occurs with int and double.

[Alan Knight, 2015-01-27 21:36:41]

Still don't love the num, but it's OK. LGTM.

[Jacob, 2015-01-27 21:36:58]

On 2015/01/27 21:10:18, Alan Knight wrote:
>
https://codereview.chromium.org/878603009/diff/1/lib/src/intl/number_format.dart
> File lib/src/intl/number_format.dart (right):
> 
>
https://codereview.chromium.org/878603009/diff/1/lib/src/intl/number_format.d...
> lib/src/intl/number_format.dart:713: num parsed = int.parse(normalizedText,
> onError: (message) => null);
> It's minor but I don't love this. Especially when we're compiling to JS, which
> doesn't distinguish between ints and doubles, it seems gratuitous.
> 
> I don't know if this is a symptom of a more general issue, or if this really
> just occurs with int and double.

yep. distinguishing between int and double in JavaScript is low value.

[Jacob, 2015-01-27 21:41:10]

Committed patchset #1 (id:1) manually as
c5295706761d67143e2d54a91d16d214d26c58bf (presubmit successful).