Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 878323002: - Move timer implementation closer to the rest of message handling. (Closed)

Created:
5 years, 11 months ago by Ivan Posva
Modified:
5 years, 10 months ago
Reviewers:
zra, Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Søren Gjesse
Visibility:
Public.

Description

- Move timer implementation closer to the rest of message handling. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=43225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -484 lines) Patch
M runtime/bin/common_patch.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M runtime/bin/dartutils.cc View 2 chunks +14 lines, -15 lines 0 comments Download
A runtime/lib/async_patch.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/lib/async_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/lib/isolate_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + runtime/lib/timer_impl.dart View 5 chunks +8 lines, -6 lines 0 comments Download
M runtime/lib/timer_patch.dart View 3 chunks +10 lines, -6 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/iolib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/io/timer_impl.dart View 1 chunk +0 lines, -441 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ivan Posva
5 years, 11 months ago (2015-01-27 23:45:05 UTC) #2
zra
lgtm
5 years, 11 months ago (2015-01-28 00:17:54 UTC) #3
Ivan Posva
Committed patchset #1 (id:1) manually as r43225 (presubmit successful).
5 years, 11 months ago (2015-01-28 00:39:43 UTC) #4
Søren Gjesse
5 years, 10 months ago (2015-01-28 08:43:36 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698