Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 877753008: Fix shift in source map positions. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, bakster
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix shift in source map positions. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43352

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Add test. #

Total comments: 2

Patch Set 4 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -17 lines) Patch
M pkg/compiler/lib/src/io/line_column_provider.dart View 3 chunks +10 lines, -6 lines 0 comments Download
A tests/compiler/dart2js/line_column_provider_test.dart View 1 2 3 1 chunk +84 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/source_map_d2js_validity_test.dart View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/source_map_deferred_d2js_validity_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/source_map_validator_helper.dart View 1 2 3 4 chunks +50 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Johnni Winther
5 years, 10 months ago (2015-02-02 09:45:00 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/877753008/diff/20001/pkg/compiler/lib/src/io/line_column_provider.dart File pkg/compiler/lib/src/io/line_column_provider.dart (right): https://codereview.chromium.org/877753008/diff/20001/pkg/compiler/lib/src/io/line_column_provider.dart#newcode74 pkg/compiler/lib/src/io/line_column_provider.dart:74: String toString() { keep? https://codereview.chromium.org/877753008/diff/20001/tests/compiler/dart2js/source_map_d2js_validity_test.dart File tests/compiler/dart2js/source_map_d2js_validity_test.dart (right): ...
5 years, 10 months ago (2015-02-02 10:17:57 UTC) #3
Johnni Winther
On 2015/02/02 10:17:57, floitsch wrote: > LGTM. > > https://codereview.chromium.org/877753008/diff/20001/pkg/compiler/lib/src/io/line_column_provider.dart > File pkg/compiler/lib/src/io/line_column_provider.dart (right): > ...
5 years, 10 months ago (2015-02-02 10:21:27 UTC) #4
floitsch
On 2015/02/02 10:21:27, Johnni Winther wrote: > On 2015/02/02 10:17:57, floitsch wrote: > > LGTM. ...
5 years, 10 months ago (2015-02-02 10:28:30 UTC) #5
floitsch
Still LGTM. https://codereview.chromium.org/877753008/diff/40001/tests/compiler/dart2js/line_column_provider_test.dart File tests/compiler/dart2js/line_column_provider_test.dart (right): https://codereview.chromium.org/877753008/diff/40001/tests/compiler/dart2js/line_column_provider_test.dart#newcode51 tests/compiler/dart2js/line_column_provider_test.dart:51: test(List events, Map<int, List<int>> expectedPositions) { move ...
5 years, 10 months ago (2015-02-02 10:28:48 UTC) #6
Johnni Winther
https://codereview.chromium.org/877753008/diff/20001/pkg/compiler/lib/src/io/line_column_provider.dart File pkg/compiler/lib/src/io/line_column_provider.dart (right): https://codereview.chromium.org/877753008/diff/20001/pkg/compiler/lib/src/io/line_column_provider.dart#newcode74 pkg/compiler/lib/src/io/line_column_provider.dart:74: String toString() { On 2015/02/02 10:17:57, floitsch wrote: > ...
5 years, 10 months ago (2015-02-02 10:49:26 UTC) #7
Johnni Winther
5 years, 10 months ago (2015-02-02 10:55:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 43352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698