Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 877553009: Add some basic interfaces that will be used for the test runner. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some basic interfaces that will be used for the test runner. So far these interfaces don't really do anything, so there aren't any tests. Future commits will use these as a foundation. R=kevmoo@google.com See #2 Committed: https://github.com/dart-lang/unittest/commit/96e72c1fa40122e88bfde7972f5560898e8553c7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix analysis errors. #

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -0 lines) Patch
A lib/src/live_test.dart View 1 2 1 chunk +104 lines, -0 lines 0 comments Download
A lib/src/live_test_controller.dart View 1 1 chunk +128 lines, -0 lines 0 comments Download
A lib/src/state.dart View 1 1 chunk +106 lines, -0 lines 0 comments Download
A lib/src/suite.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A lib/src/test.dart View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 10 months ago (2015-02-04 23:41:11 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/877553009/diff/1/lib/src/live_test.dart File lib/src/live_test.dart (right): https://codereview.chromium.org/877553009/diff/1/lib/src/live_test.dart#newcode29 lib/src/live_test.dart:29: /// The test that's running. The running test.
5 years, 10 months ago (2015-02-04 23:45:41 UTC) #2
nweiz
Code review changes
5 years, 10 months ago (2015-02-05 00:44:14 UTC) #4
nweiz
https://codereview.chromium.org/877553009/diff/1/lib/src/live_test.dart File lib/src/live_test.dart (right): https://codereview.chromium.org/877553009/diff/1/lib/src/live_test.dart#newcode29 lib/src/live_test.dart:29: /// The test that's running. On 2015/02/04 23:45:41, kevmoo ...
5 years, 10 months ago (2015-02-05 00:44:49 UTC) #5
nweiz
5 years, 10 months ago (2015-02-05 00:45:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
96e72c1fa40122e88bfde7972f5560898e8553c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698