Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 87743002: Make dart:io unit-tests pass the analyzer. (Closed)

Created:
7 years ago by Anders Johnsen
Modified:
7 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make dart:io unit-tests pass the analyzer. BUG=http://code.google.com/p/dart/issues/detail?id=7066 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -61 lines) Patch
M tests/standalone/io/http_cookie_date_test.dart View 1 chunk +24 lines, -3 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 1 chunk +28 lines, -8 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +32 lines, -14 lines 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 chunk +27 lines, -8 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years ago (2013-11-26 08:11:32 UTC) #1
Søren Gjesse
lgtm lgtm - sigh
7 years ago (2013-11-26 08:37:47 UTC) #2
Anders Johnsen
7 years ago (2013-11-26 08:38:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698