Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 877163002: Upstream folding instanceof on a constant. (Closed)

Created:
5 years, 11 months ago by rmacnak
Modified:
5 years, 11 months ago
Reviewers:
regis, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Upstream folding instanceof on a constant. Doesn't deal with instanceof a generic type. R=regis@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M runtime/vm/constant_propagator.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 11 months ago (2015-01-27 19:22:18 UTC) #2
regis
LGTM
5 years, 11 months ago (2015-01-27 19:50:46 UTC) #3
srdjan
lgtm
5 years, 11 months ago (2015-01-27 22:02:37 UTC) #4
rmacnak
5 years, 11 months ago (2015-01-27 22:17:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698