Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 876653002: dart2js: move mapTypeToInterceptor generation to interceptor_stub_generator. and rename to typeToIn… (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
herhut, sra1
CC:
reviews_dartlang.org, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: move mapTypeToInterceptor generation to interceptor_stub_generator. and rename to typeToInterceptorMap. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43183

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -65 lines) Patch
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 2 chunks +55 lines, -1 line 1 comment Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart View 2 chunks +10 lines, -55 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/interceptors.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
https://codereview.chromium.org/876653002/diff/1/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart File pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart (right): https://codereview.chromium.org/876653002/diff/1/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart#newcode322 pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:322: jsAst.ArrayInitializer generateTypeToInterceptorMap() { code is copied over from interceptor_emitter.
5 years, 11 months ago (2015-01-26 13:42:31 UTC) #2
herhut
lgtm
5 years, 11 months ago (2015-01-26 14:35:28 UTC) #3
floitsch
5 years, 11 months ago (2015-01-27 13:05:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43183 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698