Issue 876633005: Use async/await in edit_domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 876633005: Use async/await in edit_domain. (Closed)

Created:
5 years, 11 months ago by scheglov

Modified:
5 years, 11 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use async/await in edit_domain. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43162

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -97 lines)			Patch
	M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View		3 chunks	+79 lines, -97 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 (id:1) manually as 43162 (presubmit successful).

5 years, 11 months ago (2015-01-26 23:13:51 UTC) #3

Paul Berry

5 years, 11 months ago (2015-01-26 23:14:21 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/876633005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/876633005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:311: return
_sendResultResponse();
This looks strange because _sendResultResponse() returns void.  Can we change it
to:

_sendResultResponse();
return;

(similar comment applies to the other calls to _sendResultResponse() below)

https://codereview.chromium.org/876633005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:358: _init(RefactoringKind
kind, String file,
Nit: annotate that the return type of the function is Future.

Expand Messages | Collapse Messages