Issue 87643003: Disable profiler, as profiler shutdown is racing with isolates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87643003: Disable profiler, as profiler shutdown is racing with isolates. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
Søren Gjesse, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable profiler, as profiler shutdown is racing with isolates. Some tests using isolates, crashes with the following assertion error: runtime/vm/profiler.cc:237: error: expected: initialized_ It turns out that ProfileManager::Shutdown is called, while there are still isolates running. The comment in runtime/vm/dart.cc:152 seams to explain the issue. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30666

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/profiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Forgot to mention how to repro (happens in one out of maybe 100): out/DebugIA32/dart --short_socket_write ...

7 years ago (2013-11-26 09:36:56 UTC) #2

Anders Johnsen

7 years ago (2013-11-26 09:41:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r30666 (presubmit successful).

Expand Messages | Collapse Messages