Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 875443002: Store pc offset instead of absolute pc in the pc descriptors. (Closed)

Created:
5 years, 11 months ago by Florian Schneider
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Store pc offset instead of absolute pc in the pc descriptors. This saves space on 64-bit platforms as the offset is stored as a uint32_t compared to a pointer-size absolute address. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43100

Patch Set 1 #

Patch Set 2 : fixed arm/mips/arm64 build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M runtime/vm/code_descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_descriptors_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +9 lines, -15 lines 0 comments Download
M runtime/vm/object_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 3 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/stack_frame.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
5 years, 11 months ago (2015-01-23 10:35:39 UTC) #2
Vyacheslav Egorov (Google)
lgtm
5 years, 11 months ago (2015-01-23 12:00:36 UTC) #4
Florian Schneider
Committed patchset #2 (id:20001) manually as r43100 (presubmit successful).
5 years, 11 months ago (2015-01-23 12:30:20 UTC) #5
srdjan
5 years, 11 months ago (2015-01-23 16:57:42 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698