Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 875413002: dart2js: add mangled-global-names embedded global to new emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: add mangled-global-names embedded global to new emitter. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43236

Patch Set 1 #

Patch Set 2 : Rebase. Change comment style. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 chunks +5 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
5 years, 10 months ago (2015-01-27 12:12:52 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-01-28 10:10:32 UTC) #4
floitsch
5 years, 10 months ago (2015-01-28 13:04:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43236 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698