Issue 875323002: Cleanup IntX to implement Comparable<FixNum> which is more descriptive than Comparable as it would …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 875323002: Cleanup IntX to implement Comparable<FixNum> which is more descriptive than Comparable as it would … (Closed)

Created:
5 years, 11 months ago by Jacob

Modified:
5 years, 10 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Cleanup IntX to implement Comparable<FixNum> which is more descriptive than Comparable as it would be unsafe to attempt to sort an array with both int and FixNum. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=43365

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -21 lines)			Patch
M	pkg/fixnum/lib/src/int32.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/fixnum/lib/src/int64.dart	View	2 chunks	+7 lines, -16 lines	0 comments	Download
M	pkg/fixnum/lib/src/intx.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	pkg/fixnum/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Jacob

5 years, 10 months ago (2015-02-02 22:54:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43365 (presubmit successful).