Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 875163004: Support [AssumeDynamic] and [TrustTypeAnnotations] in the inferrer. (Closed)

Created:
5 years, 10 months ago by herhut
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support [AssumeDynamic] and [TrustTypeAnnotations] in the inferrer. BUG= R=floitsch@google.com, johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43550

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -14 lines) Patch
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 5 chunks +15 lines, -7 lines 0 comments Download
M pkg/expect/lib/expect.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 4 chunks +50 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
herhut
5 years, 10 months ago (2015-02-06 10:37:28 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/875163004/diff/1/tests/compiler/dart2js/expect_annotations_test.dart File tests/compiler/dart2js/expect_annotations_test.dart (right): https://codereview.chromium.org/875163004/diff/1/tests/compiler/dart2js/expect_annotations_test.dart#newcode66 tests/compiler/dart2js/expect_annotations_test.dart:66: print("$parameter $type"); Move this to the [reason] (third) ...
5 years, 10 months ago (2015-02-06 10:49:39 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 10 months ago (2015-02-06 10:49:54 UTC) #6
floitsch
LGTM. https://codereview.chromium.org/875163004/diff/1/tests/compiler/dart2js/expect_annotations_test.dart File tests/compiler/dart2js/expect_annotations_test.dart (right): https://codereview.chromium.org/875163004/diff/1/tests/compiler/dart2js/expect_annotations_test.dart#newcode66 tests/compiler/dart2js/expect_annotations_test.dart:66: print("$parameter $type"); debug print.
5 years, 10 months ago (2015-02-06 10:54:56 UTC) #8
herhut
https://codereview.chromium.org/875163004/diff/1/tests/compiler/dart2js/expect_annotations_test.dart File tests/compiler/dart2js/expect_annotations_test.dart (right): https://codereview.chromium.org/875163004/diff/1/tests/compiler/dart2js/expect_annotations_test.dart#newcode66 tests/compiler/dart2js/expect_annotations_test.dart:66: print("$parameter $type"); On 2015/02/06 10:49:39, Johnni Winther wrote: > ...
5 years, 10 months ago (2015-02-06 11:37:53 UTC) #10
herhut
5 years, 10 months ago (2015-02-06 11:38:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43550 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698