Issue 874373003: Library dependencies server API updates (to pass package maps).

Issue 874373003: Library dependencies server API updates (to pass package maps). (Closed)

Created:
5 years, 11 months ago by pquitslund

Modified:
5 years, 11 months ago

Reviewers:
scheglov, jwren, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1, jwren

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Library dependencies server API updates (to pass package maps). R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43193

Patch Set 5 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -45 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetLibraryDependenciesConsumer.java	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/LibraryDependenciesProcessor.java	View	1 2 3	4 chunks	+21 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java	View	1 2 3	4 chunks	+29 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	1 2 3	1 chunk	+19 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_analysis.dart	View	1 2 3	1 chunk	+5 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	1 2 3	6 chunks	+19 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart	View	1 2 3	3 chunks	+27 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 2 3	2 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1 2 3	1 chunk	+29 lines, -13 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source.dart	View	1 2 3	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

https://codereview.chromium.org/874373003/diff/40001/pkg/analyzer/lib/src/generated/source.dart File pkg/analyzer/lib/src/generated/source.dart (right): https://codereview.chromium.org/874373003/diff/40001/pkg/analyzer/lib/src/generated/source.dart#newcode606 pkg/analyzer/lib/src/generated/source.dart:606: return resolver != null ? resolver.packageMap : null; Unless ...

5 years, 11 months ago (2015-01-26 21:40:08 UTC) #5

pquitslund

Thanks for the feedback. As per our conversation, I've enhanced the result to include context ...

5 years, 11 months ago (2015-01-26 23:36:32 UTC) #6

Brian Wilkerson

LGTM. I think the spec would be more readable if we defined a new type ...

5 years, 11 months ago (2015-01-27 00:48:49 UTC) #7

pquitslund

5 years, 11 months ago (2015-01-27 17:23:20 UTC) #9

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as r43193 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages