Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 874083002: add periodic delay in analysis to reduce request processing latency (Closed)

Created:
5 years, 11 months ago by danrubel
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

add periodic delay in analysis to reduce request processing latency BUG= R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43127

Patch Set 1 #

Patch Set 2 : add flag to disable delay along with comments explaining why the workaround was added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 3 chunks +34 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
danrubel
5 years, 11 months ago (2015-01-25 04:59:41 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-25 05:15:42 UTC) #3
Brian Wilkerson
As per the e-mail thread, we should at least add a flag to disable the ...
5 years, 11 months ago (2015-01-25 17:09:09 UTC) #4
danrubel
On 2015/01/25 17:09:09, Brian Wilkerson wrote: > As per the e-mail thread, we should at ...
5 years, 11 months ago (2015-01-25 21:07:04 UTC) #5
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-25 21:39:01 UTC) #6
danrubel
5 years, 11 months ago (2015-01-26 02:10:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43127 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698