Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 873223002: dart2js: extract a native-blob handler and make it emitter-independent. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, zarah, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: extract a native-blob handler and make it emitter-independent. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43182

Patch Set 1 #

Patch Set 2 : Rename nativeBlob to nativeInfo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -53 lines) Patch
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 1 chunk +92 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 chunks +15 lines, -53 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 11 months ago (2015-01-26 13:39:12 UTC) #2
herhut
lgtm
5 years, 11 months ago (2015-01-26 14:42:06 UTC) #3
floitsch
Renamed nativeBlobHandler to nativeInfoHandler (consistent with rename of previous CL).
5 years, 11 months ago (2015-01-27 13:03:31 UTC) #4
floitsch
5 years, 11 months ago (2015-01-27 13:03:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698