Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 87283003: Make the root zone's schduleMicrotask and create[Periodic]Timer bind the callback. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the root zone's schduleMicrotask and create[Periodic]Timer bind the callback. BUG= http://dartbug.com/15232 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=30708 Committed: https://code.google.com/p/dart/source/detail?r=30711

Patch Set 1 #

Patch Set 2 : Changed tests. #

Total comments: 2

Patch Set 3 : Adding missing typo fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/lib/async/zone_empty_description2_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-11-26 07:06:57 UTC) #1
floitsch
LGTM. You will need to update the co19 status file.
7 years ago (2013-11-26 10:50:32 UTC) #2
Lasse Reichstein Nielsen
I don't think the co19 tests have landed in dart yet, but there were a ...
7 years ago (2013-11-26 14:58:41 UTC) #3
floitsch
On 2013/11/26 14:58:41, Lasse Reichstein Nielsen wrote: > I don't think the co19 tests have ...
7 years ago (2013-11-26 15:23:42 UTC) #4
Lasse Reichstein Nielsen
ACK, upload failed due to lack of a press on return.
7 years ago (2013-11-27 06:59:35 UTC) #5
floitsch
Still LGTM. https://codereview.chromium.org/87283003/diff/20001/tests/lib/async/zone_empty_description2_test.dart File tests/lib/async/zone_empty_description2_test.dart (right): https://codereview.chromium.org/87283003/diff/20001/tests/lib/async/zone_empty_description2_test.dart#newcode17 tests/lib/async/zone_empty_description2_test.dart:17: // The createTimer functions on the Zone ...
7 years ago (2013-11-27 10:05:15 UTC) #6
Lasse Reichstein Nielsen
Committed patchset #2 manually as r30708 (presubmit successful).
7 years ago (2013-11-27 11:42:15 UTC) #7
Lasse Reichstein Nielsen
7 years ago (2013-11-27 11:55:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r30711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698