Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 872373003: Reapply "Add a shrinking reduction for dead continuation parameters." (Closed)

Created:
5 years, 11 months ago by Kevin Millikin (Google)
Modified:
5 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Reapply "Add a shrinking reduction for dead continuation parameters." This reapplies SVN revision r43093 with bug fixes. A failing assert was fixed, and continuation eta-reduction was restricted to not change non-call continuations into call continuations. If these were to occur, they risk duplicating code and so are not always on optimization. BUG= R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=43135

Patch Set 1 #

Patch Set 2 : The actual fix. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -80 lines) Patch
M pkg/analyzer2dart/test/end2end_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 6 chunks +11 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 13 chunks +187 lines, -25 lines 1 comment Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 4 chunks +93 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Kevin Millikin (Google)
Reapply this while disallowing continuation eta-reduction that turns a non-call continuation into a call continuation ...
5 years, 11 months ago (2015-01-26 11:25:58 UTC) #2
Kevin Millikin (Google)
The fix is in the diff from patch set 1 -> 2.
5 years, 11 months ago (2015-01-26 11:26:17 UTC) #3
asgerf
Still LGTM https://codereview.chromium.org/872373003/diff/20001/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart File pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart (right): https://codereview.chromium.org/872373003/diff/20001/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart#newcode290 pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart:290: // Do not perform reductions replace a ...
5 years, 11 months ago (2015-01-26 12:56:57 UTC) #4
Kevin Millikin (Google)
5 years, 11 months ago (2015-01-26 13:51:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698