Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 871863006: Enable enums by default. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Enable enums by default. BUG=http://dartbug.com/21885 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43334

Patch Set 1 #

Patch Set 2 : Remove the field in Compiler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -38 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 7 chunks +0 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 3 chunks +2 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 6 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 10 months ago (2015-01-30 11:20:10 UTC) #2
floitsch
LGTM.
5 years, 10 months ago (2015-01-30 12:00:39 UTC) #3
Johnni Winther
5 years, 10 months ago (2015-01-30 12:21:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698