Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 871373012: Make service lifecycle checks thread safe (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make service lifecycle checks thread safe RunLoop tests were getting wedged trying to communicate with the vm-isolate that was shutdown before a test isolate started up. dartbug.com/22219 This CL: * ensures that any 'is the service running' checks are done with a lock held. * Normalizes trace messages printed from the vm-service. Committed: https://code.google.com/p/dart/source/detail?r=43348

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -41 lines) Patch
M runtime/vm/service.h View 3 chunks +8 lines, -17 lines 0 comments Download
M runtime/vm/service.cc View 20 chunks +72 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 10 months ago (2015-01-30 20:24:21 UTC) #2
Cutch
On 2015/01/30 20:24:21, Cutch wrote: TBR
5 years, 10 months ago (2015-01-30 22:02:58 UTC) #3
Cutch
Committed patchset #3 (id:40001) manually as 43348 (presubmit successful).
5 years, 10 months ago (2015-01-30 22:03:26 UTC) #4
siva
5 years, 10 months ago (2015-01-31 00:22:11 UTC) #5
Message was sent while issue was closed.
Can you post the backtrace of the thread that was stuck.
Some of the code here seems to only be run by the service isolate so it is not
clear.

Powered by Google App Engine
This is Rietveld 408576698