Issue 22188. Verify that none or all execution flows return.

Issue 22188. Verify that none or all execution flows return.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22188

Committed: https://code.google.com/p/dart/source/detail?r=43663

[Paul Berry, 2015-02-10 18:25:16]

lgtm

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/refactoring/extract_method_test.dart
(right):

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/refactoring/extract_method_test.dart:456:
"Selected statements contain a return statement, but not all possible "
Nit: it would be nice to put this string in a const somewhere so that we don't
have to duplicate it between the implementation and the test.

[Brian Wilkerson, 2015-02-10 18:29:03]

LGTM

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/extract_method.dart
(right):

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_method.dart:708: static
bool _endsWithReturnStatement(Statement statement) {
Should this be using ExitDetector?

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_method.dart:714: return
statements.isNotEmpty && _endsWithReturnStatement(statements[0]);
Shouldn't this be "statements.last"?

[scheglov, 2015-02-10 19:12:59]

New patchsets have been uploaded after l-g-t-m from
paulberry@google.com,brianwilkerson@google.com

[scheglov, 2015-02-10 19:13:42]

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/extract_method.dart
(right):

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_method.dart:708: static
bool _endsWithReturnStatement(Statement statement) {
On 2015/02/10 18:29:03, Brian Wilkerson wrote:
> Should this be using ExitDetector?

Great idea.
Thank you!

https://codereview.chromium.org/871013012/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_method.dart:714: return
statements.isNotEmpty && _endsWithReturnStatement(statements[0]);
On 2015/02/10 18:29:03, Brian Wilkerson wrote:
> Shouldn't this be "statements.last"?

Acknowledged.

[scheglov, 2015-02-10 19:14:10]

Committed patchset #2 (id:20001) manually as 43663 (presubmit successful).