Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 870883006: Fixed implementation of ArgResults.options to really use Iterable<String> instead of Iterable<dynam… (Closed)

Created:
5 years, 11 months ago by Jacob
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/args.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed implementation of ArgResults.options to really use Iterable<String> instead of Iterable<dynamic> cast to Iterable<String>. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/args/commit/bd16665b292d56c6d8551700e4551f2099f6697e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/arg_results.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jacob
5 years, 11 months ago (2015-01-23 21:02:31 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 11 months ago (2015-01-23 21:06:29 UTC) #3
Jacob
5 years, 11 months ago (2015-01-23 21:22:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd16665b292d56c6d8551700e4551f2099f6697e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698