Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 869773007: Port _echo, etc commands to RPC (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Port _echo, etc commands to RPC BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=43447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -48 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 3 chunks +8 lines, -19 lines 0 comments Download
M runtime/observatory/test/echo_test.dart View 2 chunks +9 lines, -11 lines 0 comments Download
A runtime/observatory/test/malformed_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M runtime/vm/service.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 9 chunks +25 lines, -17 lines 0 comments Download
M runtime/vm/service/service.idl View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 10 months ago (2015-02-03 22:45:56 UTC) #2
turnidge
lgtm
5 years, 10 months ago (2015-02-03 23:16:55 UTC) #3
Cutch
5 years, 10 months ago (2015-02-03 23:17:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698