Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 869513003: dart2js: Move metadata from old_emitter to shared directory. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Move metadata from old_emitter to shared directory. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43288

Patch Set 1 #

Total comments: 4

Messages

Total messages: 4 (1 generated)
floitsch
https://codereview.chromium.org/869513003/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart File pkg/compiler/lib/src/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/869513003/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart#newcode61 pkg/compiler/lib/src/js_emitter/code_emitter_task.dart:61: metadataEmitter.emitter = oldEmitter; I intend to update this in ...
5 years, 10 months ago (2015-01-29 14:36:30 UTC) #2
herhut
lgtm https://codereview.chromium.org/869513003/diff/1/pkg/compiler/lib/src/js_emitter/type_test_generator.dart File pkg/compiler/lib/src/js_emitter/type_test_generator.dart (left): https://codereview.chromium.org/869513003/diff/1/pkg/compiler/lib/src/js_emitter/type_test_generator.dart#oldcode31 pkg/compiler/lib/src/js_emitter/type_test_generator.dart:31: OldEmitter get oldEmitter => emitterTask.oldEmitter; On 2015/01/29 14:36:30, ...
5 years, 10 months ago (2015-01-29 14:46:27 UTC) #3
floitsch
5 years, 10 months ago (2015-01-29 14:54:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698