Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 869223003: Revert "Add a shrinking reduction for dead continuation parameters." (Closed)

Created:
5 years, 11 months ago by Kevin Millikin (Google)
Modified:
5 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Add a shrinking reduction for dead continuation parameters." This reverts svn revision r43093, due to failures in dart2dart. It clashes with the commit just before it which has changed the type of FunctionDefinition parameters. Also, continuation eta-reduction can destroy a dead parameter reduction. In this case, it's not obvious which reduction we actually want. So though the fixes are simple, I will back this change out and reevaluate it. R=asgerf@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -291 lines) Patch
M pkg/analyzer2dart/test/end2end_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 6 chunks +5 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 13 chunks +25 lines, -153 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 4 chunks +14 lines, -93 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
5 years, 11 months ago (2015-01-23 13:17:42 UTC) #1
Kevin Millikin (Google)
I discussed this offline with Asger, and we'll just prohibit continuation eta-reductions that turn a ...
5 years, 11 months ago (2015-01-23 13:44:26 UTC) #2
Kevin Millikin (Google)
5 years, 11 months ago (2015-01-23 13:44:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43105 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698