Clean up unittest a bunch.

Clean up unittest a bunch.

This gets rid of all uses of part, adds documentation where it was missing, and
fixes a number of style issues. It's a backwards-compatible change designed to
make the package more clear and comprehensible in preparation for larger
changes to come.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/unittest/commit/c55a076b1d642185e5456a9792685d805133c058

[kevmoo, 2015-01-23 02:41:10]

In general I like it. Two things:

1) I was in the process of merging in the matcher/unittest refactor I had
started pre-GitHub. The two CLs (which need just a bit of cleanup) are here

unittest: https://codereview.chromium.org/869053002/
matcher: https://codereview.chromium.org/867133002/

This was mostly a copy-paste from the existing patch, which will be made a bit
more difficult if you land first. Happy to discuss.

2) import '../unittest.dart' feels like a smell. Are there bits of
lib/unittest.dart that we can move into src/XYZ and then export in unittest?

https://codereview.chromium.org/869043002/diff/1/lib/src/expected_function.dart
File lib/src/expected_function.dart (right):

https://codereview.chromium.org/869043002/diff/1/lib/src/expected_function.da...
lib/src/expected_function.dart:168: // Don't run the callback if the test is
done. We don't throw here as this
long lines

[kevmoo, 2015-01-27 23:29:17]

On 2015/01/23 02:41:10, kevmoo wrote:
> In general I like it. Two things:
> 
> 1) I was in the process of merging in the matcher/unittest refactor I had
> started pre-GitHub. The two CLs (which need just a bit of cleanup) are here
> 
> unittest: https://codereview.chromium.org/869053002/
> matcher: https://codereview.chromium.org/867133002/
> 
> This was mostly a copy-paste from the existing patch, which will be made a bit
> more difficult if you land first. Happy to discuss.
> 
> 2) import '../unittest.dart' feels like a smell. Are there bits of
> lib/unittest.dart that we can move into src/XYZ and then export in unittest?
> 
>
https://codereview.chromium.org/869043002/diff/1/lib/src/expected_function.dart
> File lib/src/expected_function.dart (right):
> 
>
https://codereview.chromium.org/869043002/diff/1/lib/src/expected_function.da...
> lib/src/expected_function.dart:168: // Don't run the callback if the test is
> done. We don't throw here as this
> long lines

Hopefully I didn't make the rebase too difficult.

[kevmoo, 2015-01-28 00:54:27]

lgtm

[nweiz, 2015-01-28 01:00:45]

Code review changes

[nweiz, 2015-01-28 01:20:43]

Committed patchset #2 (id:20001) manually as
c55a076b1d642185e5456a9792685d805133c058 (presubmit successful).