Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 868873002: Library dependency service tests. (Closed)

Created:
5 years, 11 months ago by pquitslund
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
A pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/services/dependencies/test_all.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
pquitslund
5 years, 11 months ago (2015-01-22 22:23:26 UTC) #2
scheglov
LGTM https://codereview.chromium.org/868873002/diff/1/pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart File pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart (right): https://codereview.chromium.org/868873002/diff/1/pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart#newcode26 pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart:26: addSource('/lib4.dart', 'import "lib5.dart";'); I would add a cycle ...
5 years, 11 months ago (2015-01-22 22:26:45 UTC) #3
pquitslund
https://codereview.chromium.org/868873002/diff/1/pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart File pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart (right): https://codereview.chromium.org/868873002/diff/1/pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart#newcode26 pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart:26: addSource('/lib4.dart', 'import "lib5.dart";'); On 2015/01/22 22:26:45, scheglov wrote: > ...
5 years, 11 months ago (2015-01-22 22:38:47 UTC) #4
scheglov
LGTM
5 years, 11 months ago (2015-01-22 22:39:36 UTC) #5
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-22 23:51:00 UTC) #6
pquitslund
5 years, 11 months ago (2015-01-26 18:28:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698