Issue 868643002: Revert "Change signature of lookupConstructor to only require a name."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 868643002: Revert "Change signature of lookupConstructor to only require a name." (Closed)

Created:
5 years, 11 months ago by herhut

Modified:
5 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "Change signature of lookupConstructor to only require a name." This reverts revision 43067. BUG= TBR=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43068

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -47 lines)			Patch
M	pkg/analyzer2dart/lib/src/modely.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/compile_time_constants.dart	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View	4 chunks	+14 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/elements/elements.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/elements/modelx.dart	View	1 chunk	+15 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 chunk	+9 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

herhut

Committed patchset #1 (id:1) manually as 43068 (presubmit successful).

5 years, 11 months ago (2015-01-22 10:46:29 UTC) #3

Message was sent while issue was closed.

LGTM.