Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 868483006: dart2js: remove additionalProperties and store it directly as nativeBlob. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, zarah, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: remove additionalProperties and store it directly as nativeBlob. R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=43181

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rename nativeBlob to nativeInfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -36 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 3 chunks +6 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 3 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 4 chunks +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 2 chunks +1 line, -7 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
floitsch
5 years, 10 months ago (2015-01-26 13:37:18 UTC) #2
herhut
lgtm https://codereview.chromium.org/868483006/diff/1/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/868483006/diff/1/pkg/compiler/lib/src/js_emitter/model.dart#newcode198 pkg/compiler/lib/src/js_emitter/model.dart:198: String nativeBlob; For me, a BLOB is a ...
5 years, 10 months ago (2015-01-26 14:58:23 UTC) #3
floitsch
https://codereview.chromium.org/868483006/diff/1/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/868483006/diff/1/pkg/compiler/lib/src/js_emitter/model.dart#newcode198 pkg/compiler/lib/src/js_emitter/model.dart:198: String nativeBlob; On 2015/01/26 14:58:22, herhut wrote: > For ...
5 years, 10 months ago (2015-01-26 18:02:26 UTC) #4
floitsch
https://codereview.chromium.org/868483006/diff/1/pkg/compiler/lib/src/js_emitter/model.dart File pkg/compiler/lib/src/js_emitter/model.dart (right): https://codereview.chromium.org/868483006/diff/1/pkg/compiler/lib/src/js_emitter/model.dart#newcode198 pkg/compiler/lib/src/js_emitter/model.dart:198: String nativeBlob; On 2015/01/26 18:02:26, floitsch wrote: > On ...
5 years, 10 months ago (2015-01-27 12:59:00 UTC) #5
floitsch
5 years, 10 months ago (2015-01-27 12:59:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698