Issue 868463003: Regenerate pub's sources and remove workarounds for fixed issues.

Issue 868463003: Regenerate pub's sources and remove workarounds for fixed issues. (Closed)

Created:
5 years, 11 months ago by nweiz

Modified:
5 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Regenerate pub's sources and remove workarounds for fixed issues. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=43057

Patch Set 2 : Code review changes #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+604 lines, -494 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/transformer_loader.dart	View		1 chunk	+7 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/entrypoint.dart	View	1	2 chunks	+38 lines, -38 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/executable.dart	View		2 chunks	+25 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/global_packages.dart	View		1 chunk	+35 lines, -41 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/hosted.dart	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/validator/dependency.dart	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/README.md	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/barback/transformer_loader.dart	View		3 chunks	+37 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/command/cache_repair.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/command/serve.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/command_runner.dart	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart	View		6 chunks	+182 lines, -127 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/executable.dart	View		2 chunks	+72 lines, -55 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/global_packages.dart	View		3 chunks	+72 lines, -40 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/source/git.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/source/hosted.dart	View		1 chunk	+50 lines, -50 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart	View		1 chunk	+71 lines, -69 lines	0 comments	Download
M	tests/lib/analyzer/analyze_library.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/868463003/diff/1/sdk/lib/_internal/pub/lib/src/entrypoint.dart File sdk/lib/_internal/pub/lib/src/entrypoint.dart (right): https://codereview.chromium.org/868463003/diff/1/sdk/lib/_internal/pub/lib/src/entrypoint.dart#newcode216 sdk/lib/_internal/pub/lib/src/entrypoint.dart:216: // TODO(nweiz): only get assets from [dependenciesToPrecompile] so ...

5 years, 11 months ago (2015-01-22 00:50:17 UTC) #2

nweiz

5 years, 11 months ago (2015-01-22 01:07:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43057 (presubmit successful).

Expand Messages | Collapse Messages