Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 868283005: dart2js: make "CREATE_JS_ISOLATE" an embedded global. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: make "CREATE_JS_ISOLATE" an embedded global. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/foreign_helper.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/isolate_helper.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 10 months ago (2015-02-09 15:59:46 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-02-10 08:45:27 UTC) #3
floitsch
5 years, 10 months ago (2015-02-10 13:09:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698