Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 868273003: Let the dart2dart compiler stop in case of failure. (Closed)

Created:
5 years, 11 months ago by sigurdm
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, ahe, floitsch, Kevin Millikin (Google)
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Let the dart2dart compiler stop in case of failure (errors). This is a stop-gap measure to avoid crashes BUG= dartbug.com/22085 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -207 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +0 lines, -62 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -145 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sigurdm
5 years, 11 months ago (2015-01-27 08:02:51 UTC) #2
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-27 08:26:01 UTC) #3
sigurdm
5 years, 11 months ago (2015-01-27 09:03:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698