Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 868183002: Move AnalysisServer to package ...generated to indicated that the file shouldnt be changed manually. (Closed)

Created:
5 years, 11 months ago by jwren
Modified:
5 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1, Brian Wilkerson, pquitslund, Paul Berry, keertip
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Move AnalysisServer to package ...generated to indicated that the file shouldnt be changed manually. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43119

Patch Set 1 #

Patch Set 2 : Add file that wasn't added by git. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -506 lines) Patch
M editor/tools/plugins/com.google.dart.server/META-INF/MANIFEST.MF View 1 chunk +1 line, -0 lines 0 comments Download
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 chunk +0 lines, -489 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/AnalysisServer.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 2 chunks +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/AbstractServerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/AbstractRemoteServerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/model/AnalysisServerData.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/completion/DartSuggestionReceiver.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/DartProjectManager.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartPriorityFilesHelper_NEW.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightingManager_NEW.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/functions/PositionElement.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/internal/text/dart/DartPriorityFilesHelper_NEW_Test.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_analysis_server.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jwren
5 years, 11 months ago (2015-01-23 19:52:35 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-23 20:01:35 UTC) #3
jwren
5 years, 11 months ago (2015-01-23 20:10:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698