Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 868103002: VM: Use PC offset instead of absolute PC in exception handler info. (Closed)

Created:
5 years, 11 months ago by Florian Schneider
Modified:
5 years, 11 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Use PC offset instead of absolute PC in exception handler info. Similar to the change I did for PC descriptors: We can save space by using a uint32_t for the offset, instead of a uword for the absolute pc. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43138

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M runtime/vm/code_descriptors.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 5 chunks +10 lines, -6 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 11 months ago (2015-01-23 15:34:19 UTC) #2
srdjan
lgtm https://codereview.chromium.org/868103002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/868103002/diff/1/runtime/vm/object.cc#newcode10952 runtime/vm/object.cc:10952: info->handler_pc_offset = handler_pc_offset; Could you add an assert ...
5 years, 11 months ago (2015-01-23 16:55:28 UTC) #3
Florian Schneider
https://codereview.chromium.org/868103002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/868103002/diff/1/runtime/vm/object.cc#newcode10952 runtime/vm/object.cc:10952: info->handler_pc_offset = handler_pc_offset; On 2015/01/23 16:55:28, srdjan wrote: > ...
5 years, 11 months ago (2015-01-26 15:28:53 UTC) #4
Florian Schneider
5 years, 11 months ago (2015-01-26 15:40:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698