Support constructor declarations in analyzer2dart.

Support constructor declarations in analyzer2dart.

BUG=
R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43271

[Johnni Winther, 2015-01-28 13:38:01]

johnniwinther@google.com changed reviewers:
+ herhut@google.com

[Johnni Winther, 2015-01-28 13:38:02]

https://codereview.chromium.org/867233004/diff/1/pkg/analyzer2dart/lib/src/da...
File pkg/analyzer2dart/lib/src/dart_backend.dart (left):

https://codereview.chromium.org/867233004/diff/1/pkg/analyzer2dart/lib/src/da...
pkg/analyzer2dart/lib/src/dart_backend.dart:80: void reportFatalError(Spannable
node,
Cleanup.

https://codereview.chromium.org/867233004/diff/1/pkg/analyzer2dart/lib/src/mo...
File pkg/analyzer2dart/lib/src/modely.dart (left):

https://codereview.chromium.org/867233004/diff/1/pkg/analyzer2dart/lib/src/mo...
pkg/analyzer2dart/lib/src/modely.dart:240: void set canUseNative(bool value) =>
unsupported('canUseNative');
Cleanup.

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart (right):

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart:485: if (parameter is
Parameter) parameter.parent_index = index++;
Fixes a checked mode bug for the new dart2dart backend.

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/outputter.dart (left):

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/outputter.dart:438:
assert(enclosingClass.isTopLevel);
Redundant.

[herhut, 2015-01-28 14:12:50]

ltgm w/ comments

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart (right):

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart:485: if (parameter is
Parameter) parameter.parent_index = index++;
On 2015/01/28 13:38:02, Johnni Winther wrote:
> Fixes a checked mode bug for the new dart2dart backend.

This still reads strange...

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/element...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/modelx.dart:1822: List<ParameterElement> get
parameters {
Does this have to be a List or would an Iterable do? Also, seems to be costly if
this becomes the default means to iterate over parameters.

[herhut, 2015-01-28 14:13:14]

Me no can type.

LGTM w/ comments

On 2015/01/28 14:12:50, herhut wrote:
> ltgm w/ comments
> 
>
https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
> File pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart (right):
> 
>
https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
> pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart:485: if (parameter is
> Parameter) parameter.parent_index = index++;
> On 2015/01/28 13:38:02, Johnni Winther wrote:
> > Fixes a checked mode bug for the new dart2dart backend.
> 
> This still reads strange...
> 
>
https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/element...
> File pkg/compiler/lib/src/elements/modelx.dart (right):
> 
>
https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/element...
> pkg/compiler/lib/src/elements/modelx.dart:1822: List<ParameterElement> get
> parameters {
> Does this have to be a List or would an Iterable do? Also, seems to be costly
if
> this becomes the default means to iterate over parameters.

[Johnni Winther, 2015-01-29 07:51:07]

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart (right):

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart:485: if (parameter is
Parameter) parameter.parent_index = index++;
On 2015/01/28 14:12:50, herhut wrote:
> On 2015/01/28 13:38:02, Johnni Winther wrote:
> > Fixes a checked mode bug for the new dart2dart backend.
> 
> This still reads strange...

Yes. But now its is valid, and all consistent with line 471 ;-)

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/element...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/867233004/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/modelx.dart:1822: List<ParameterElement> get
parameters {
On 2015/01/28 14:12:50, herhut wrote:
> Does this have to be a List or would an Iterable do? Also, seems to be costly
if
> this becomes the default means to iterate over parameters.

Adding a TODO to store the list directly while removing the dependency on Link
in FunctionSignature.

[Johnni Winther, 2015-01-29 07:58:53]

Committed patchset #2 (id:20001) manually as 43271 (presubmit successful).