Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 867113003: Revert r43217, r43215, r43208, r43207, and r43202. (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert r43217, r43215, r43208, r43207, and r43202. Reverting because of some isolate spawn issues (on Windows, and pub bots). Committed: https://code.google.com/p/dart/source/detail?r=43219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -1165 lines) Patch
M runtime/bin/bin.gypi View 7 chunks +3 lines, -125 lines 0 comments Download
M runtime/bin/builtin.h View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/bin/builtin.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/bin/builtin.dart View 9 chunks +137 lines, -124 lines 0 comments Download
D runtime/bin/builtin_common.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/builtin_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/builtin_nolib.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/dartutils.h View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/bin/dartutils.cc View 4 chunks +60 lines, -119 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 chunk +1 line, -14 lines 0 comments Download
M runtime/bin/main.cc View 6 chunks +77 lines, -28 lines 0 comments Download
M runtime/bin/platform.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/bin/process_macos.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/resources_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/secure_socket_unsupported.cc View 1 chunk +0 lines, -10 lines 0 comments Download
A + runtime/bin/vmservice.h View 1 chunk +3 lines, -7 lines 0 comments Download
D runtime/bin/vmservice/loader.dart View 1 chunk +0 lines, -60 lines 0 comments Download
M runtime/bin/vmservice/resources.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/server.dart View 2 chunks +1 line, -8 lines 0 comments Download
M runtime/bin/vmservice/vmservice_io.dart View 3 chunks +4 lines, -16 lines 0 comments Download
D runtime/bin/vmservice_dartium.h View 1 chunk +0 lines, -38 lines 0 comments Download
D runtime/bin/vmservice_dartium.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M runtime/bin/vmservice_impl.h View 3 chunks +7 lines, -21 lines 0 comments Download
M runtime/bin/vmservice_impl.cc View 7 chunks +57 lines, -74 lines 0 comments Download
M runtime/include/dart_api.h View 3 chunks +44 lines, -12 lines 0 comments Download
M runtime/lib/isolate.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/tools/gyp/runtime-configurations.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/class_finalizer.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_table.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/dart.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/dart.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/debugger.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M runtime/vm/service.h View 6 chunks +1 line, -23 lines 0 comments Download
M runtime/vm/service.cc View 11 chunks +71 lines, -225 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/unit_test.h View 2 chunks +6 lines, -8 lines 0 comments Download
M tests/standalone/vmservice/test_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Cutch
TBR
5 years, 10 months ago (2015-01-27 22:55:39 UTC) #2
Cutch
5 years, 10 months ago (2015-01-27 22:56:53 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698