Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 866843002: dart2js: determine if a needed class is needed without having side-effects. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: determine if a needed class is needed without having side-effects. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43107

Patch Set 1 #

Patch Set 2 : Emit classes only if they are needed. #

Patch Set 3 : Revert debug code. #

Patch Set 4 : Remove more debug code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 2 3 4 chunks +23 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
FYI: patch-set 1 shows similar code to what I used to verify that this is ...
5 years, 11 months ago (2015-01-23 14:17:49 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-23 14:37:36 UTC) #3
floitsch
5 years, 11 months ago (2015-01-23 14:44:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 43107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698