Add a working command line debugger to Observatory.

Add a working command line debugger to Observatory.

Try it!

Committed: https://code.google.com/p/dart/source/detail?r=43618

[turnidge, 2015-02-09 21:24:53]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-02-09 21:45:06]

LGTMwC

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:17:
DebuggerCommand(this.debugger, name, children)
Shouldn't all of these DebuggerCommands exists somewhere outside of the element
source? Would make them easier to reuse.

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:47: if
(!debugger.isolatePaused()) {
There is a race here if the user requests an isolate be paused two times before
we here back from the VM. Specifically, debugger.isolatePaused() will be false
*after* a request is in flight. I wonder if the isolate should have a completer
to make double requests for pause/resume safe?

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:165:
InfoBreakpointsCommand(Debugger debugger) : super(debugger, 'breakpoints', []);
80 column limit.

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/service/object.dart:1025: ObservableList breakpoints
= new ObservableList();
comment is out of date now.

[turnidge, 2015-02-09 21:53:08]

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:17:
DebuggerCommand(this.debugger, name, children)
On 2015/02/09 21:45:05, Cutch wrote:
> Shouldn't all of these DebuggerCommands exists somewhere outside of the
element
> source? Would make them easier to reuse.

Yes.  I want to leave them here until the interface firms up a bit.  Added a
TODO.

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:47: if
(!debugger.isolatePaused()) {
On 2015/02/09 21:45:06, Cutch wrote:
> There is a race here if the user requests an isolate be paused two times
before
> we here back from the VM. Specifically, debugger.isolatePaused() will be false
> *after* a request is in flight. I wonder if the isolate should have a
completer
> to make double requests for pause/resume safe?

Added a TODO on Isolate.pause.

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/debugger.dart:165:
InfoBreakpointsCommand(Debugger debugger) : super(debugger, 'breakpoints', []);
On 2015/02/09 21:45:05, Cutch wrote:
> 80 column limit.

Done.

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/866663003/diff/40001/runtime/observatory/lib/...
runtime/observatory/lib/src/service/object.dart:1025: ObservableList breakpoints
= new ObservableList();
On 2015/02/09 21:45:06, Cutch wrote:
> comment is out of date now.

Done.

[turnidge, 2015-02-09 22:04:07]

Committed patchset #5 (id:80001) manually as 43618 (presubmit successful).