Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 866473003: Expect objects in the VM-heap to be marked on shutdown verification. (Closed)

Created:
5 years, 11 months ago by koda
Modified:
5 years, 11 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Expect objects in the VM-heap to be marked on shutdown verification. This would have failed after submitting https://codereview.chromium.org/850183003/ R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=43052

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/isolate.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 11 months ago (2015-01-21 19:01:11 UTC) #1
zra
lgtm
5 years, 11 months ago (2015-01-21 19:18:55 UTC) #2
koda
5 years, 11 months ago (2015-01-21 20:30:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698