Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 866213005: dart2js: Make emitInstanceMember take a Class and not a classElement. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, herhut
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Make emitInstanceMember take a Class and not a classElement. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43108

Patch Set 1 #

Patch Set 2 : Save file... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 4 chunks +23 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 11 months ago (2015-01-23 14:21:17 UTC) #2
floitsch
Forgot to save a file...
5 years, 11 months ago (2015-01-23 14:21:55 UTC) #3
zarah
LGTM
5 years, 11 months ago (2015-01-23 14:36:24 UTC) #4
floitsch
5 years, 11 months ago (2015-01-23 14:50:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698