Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 865223002: dart2js: store call stubs in the model. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: store call stubs in the model. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43099

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -100 lines) Patch
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +71 lines, -0 lines 2 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 5 chunks +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart View 2 chunks +0 lines, -85 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 10 chunks +34 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
https://codereview.chromium.org/865223002/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right): https://codereview.chromium.org/865223002/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart#newcode49 pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:49: Map<String, jsAst.Expression> generateCallStubsForGetter( directly copied except for marked changes. ...
5 years, 11 months ago (2015-01-22 15:51:14 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-23 09:36:16 UTC) #3
floitsch
5 years, 11 months ago (2015-01-23 12:29:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43099 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698