Issue 864843002: Remove default heap size limit and add separate limit for externals.

Issue 864843002: Remove default heap size limit and add separate limit for externals. (Closed)

Created:
5 years, 11 months ago by koda

Modified:
5 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove default heap size limit and add separate limit for externals. Committed: https://code.google.com/p/dart/source/detail?r=43111

Patch Set 5 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -20 lines)			Patch
M	runtime/vm/dart.cc	View	1 2 3 4	3 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/heap.h	View	1 2 3 4	3 chunks	+4 lines, -7 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 2 3 4	3 chunks	+9 lines, -4 lines	0 comments	Download
M	runtime/vm/pages.h	View	1 2 3 4	4 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/pages.cc	View	1 2 3 4	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/pages_test.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/oom_error_stacktrace_test.dart	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/out_of_memory_test.dart	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/864843002/diff/60001/runtime/vm/heap.h File runtime/vm/heap.h (right): https://codereview.chromium.org/864843002/diff/60001/runtime/vm/heap.h#newcode62 runtime/vm/heap.h:62: static const intptr_t kCodeHeapSizeInMB = 18; Where ...

5 years, 11 months ago (2015-01-22 01:45:16 UTC) #2

koda

https://codereview.chromium.org/864843002/diff/60001/runtime/vm/heap.h File runtime/vm/heap.h (right): https://codereview.chromium.org/864843002/diff/60001/runtime/vm/heap.h#newcode62 runtime/vm/heap.h:62: static const intptr_t kCodeHeapSizeInMB = 18; On 2015/01/22 01:45:15, ...

5 years, 11 months ago (2015-01-22 03:26:08 UTC) #3

koda

Note that this change highlights an inconsistency in how we deal with out-of-memory situations. When ...

5 years, 11 months ago (2015-01-23 15:20:54 UTC) #4

koda

5 years, 11 months ago (2015-01-23 16:32:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as r43111 (presubmit successful).

Expand Messages | Collapse Messages